OCPBUGS-84517: Add terminationMessagePolicy to openshift-marketplace Cronjobs by jrangelramos · Pull Request #2800 · openshift/managed-cluster-config

jrangelramos · 2026-06-30T13:26:13Z

What type of PR is this?

bug

What this PR does / why we need it?

Adds terminationMessagePolicy: FallbackToLogsOnError to the osd-patch-subscription-source and ohss-50230-redhat-operators-recovery CronJob containers in
ns/openshift-marketplace.

This fixes the Sippy CI flake: [Monitor:termination-message-policy][sig-arch] all containers in ns/openshift-marketplace must have terminationMessagePolicy=FallbackToLogsOnError

Which Jira/Github issue(s) this PR fixes?

Fixes https://issues.redhat.com/browse/OCPBUGS-84517

Special notes for your reviewer:

Both CronJobs in openshift-marketplace were missing the policy. After this fix, the exemption for this namespace in openshift/origin can be removed.

Pre-checks (if applicable):

Tested latest changes against a cluster
Included documentation changes with PR

Summary by CodeRabbit

Bug Fixes
- Improved how termination details are captured for two background CronJob tasks, so when pods exit unexpectedly, failure information is more reliable.
- This enhances the quality of logs surfaced during operator recovery and source update workflows.

openshift-ci-robot · 2026-06-30T13:26:21Z

@jrangelramos: This pull request references Jira Issue OCPBUGS-84517, which is invalid:

expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

What type of PR is this?

bug

What this PR does / why we need it?

Adds terminationMessagePolicy: FallbackToLogsOnError to the osd-patch-subscription-source and ohss-50230-redhat-operators-recovery CronJob containers in
ns/openshift-marketplace.

This fixes the Sippy CI flake: [Monitor:termination-message-policy][sig-arch] all containers in ns/openshift-marketplace must have terminationMessagePolicy=FallbackToLogsOnError

Which Jira/Github issue(s) this PR fixes?

Fixes https://issues.redhat.com/browse/OCPBUGS-84517

Special notes for your reviewer:

Both CronJobs in openshift-marketplace were missing the policy. After this fix, the exemption for this namespace in openshift/origin can be removed.

Pre-checks (if applicable):

Tested latest changes against a cluster

Included documentation changes with PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-06-30T13:26:36Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: a4166478-2914-49bd-b3e8-c14e34dc31e0

📥 Commits

Reviewing files that changed from the base of the PR and between 410d57e and d815a53.

⛔ Files ignored due to path filters (3)

hack/00-osd-managed-cluster-config-integration.yaml.tmpl is excluded by !hack/**
hack/00-osd-managed-cluster-config-production.yaml.tmpl is excluded by !hack/**
hack/00-osd-managed-cluster-config-stage.yaml.tmpl is excluded by !hack/**

📒 Files selected for processing (2)

deploy/ohss-50230-redhat-operators-recovery/10-ohss-50230.CronJob.yaml
deploy/osd-curated-operatorsources-revert/10-osd-patch-subscription-source.CronJob.yaml

🚧 Files skipped from review as they are similar to previous changes (2)

deploy/osd-curated-operatorsources-revert/10-osd-patch-subscription-source.CronJob.yaml
deploy/ohss-50230-redhat-operators-recovery/10-ohss-50230.CronJob.yaml

Walkthrough

Two CronJob manifests add terminationMessagePolicy: FallbackToLogsOnError to their container specs.

Changes

CronJob container termination message policy

Layer / File(s)	Summary
CronJob container policy fields `deploy/ohss-50230-redhat-operators-recovery/10-ohss-50230.CronJob.yaml`, `deploy/osd-curated-operatorsources-revert/10-osd-patch-subscription-source.CronJob.yaml`	Both CronJob container specs set `terminationMessagePolicy` to `FallbackToLogsOnError`.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: adding terminationMessagePolicy to openshift-marketplace CronJobs.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR only changes two CronJob YAML manifests; no Ginkgo tests or test titles were added or modified.
Test Structure And Quality	✅ Passed	PR only adds a YAML field to two CronJobs; no Ginkgo test code or assertions were changed.
Microshift Test Compatibility	✅ Passed	The PR changes only CronJob YAML and infra templates; no Ginkgo/e2e test files or test definitions were added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No new Ginkgo/e2e tests were added; the PR only updates CronJob YAMLs, so SNO test-compatibility concerns are not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	Only `terminationMessagePolicy` was added to two CronJob containers; no replicas, anti-affinity, topology spread, or node-targeting changes were introduced.
Ote Binary Stdout Contract	✅ Passed	PR only changes CronJob YAML; no process-level code or stdout writes in OTE binaries were introduced.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	Only two CronJob YAMLs changed; no new Ginkgo e2e tests or network/IP logic was added, so the IPv6/disconnected compatibility check is not applicable.
No-Weak-Crypto	✅ Passed	Only Kubernetes CronJob YAML changed; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret-comparison code appears.
Container-Privileges	✅ Passed	Both modified CronJobs only add terminationMessagePolicy; no privileged, hostNetwork/PID/IPC, SYS_ADMIN, or allowPrivilegeEscalation settings are present.
No-Sensitive-Data-In-Logs	✅ Passed	The PR only adds terminationMessagePolicy; it introduces no new logging, and existing echoes print subscription/namespace names only.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

…CronJobs Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

jrangelramos · 2026-06-30T17:46:38Z

/jira refresh

openshift-ci-robot · 2026-06-30T17:46:45Z

@jrangelramos: This pull request references Jira Issue OCPBUGS-84517, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (5.0.0) matches configured target version for branch (5.0.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jrangelramos · 2026-07-01T12:40:43Z

hello @joshbranham @rogbas !! Could you please review this PR?

joshbranham · 2026-07-01T13:38:18Z

/lgtm
/approve

openshift-ci · 2026-07-01T13:41:36Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joshbranham, jrangelramos

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [joshbranham]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2026-07-01T14:04:37Z

@jrangelramos: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2026-07-01T14:05:41Z

@jrangelramos: Jira Issue OCPBUGS-84517: Some pull requests linked via external trackers have merged:

openshift/managed-cluster-config#2800

The following pull request, linked via external tracker, has not merged:

openshift/origin#31355 is open

All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-84517 has not been moved to the MODIFIED state.

Details

In response to this:

What type of PR is this?

bug

What this PR does / why we need it?

Adds terminationMessagePolicy: FallbackToLogsOnError to the osd-patch-subscription-source and ohss-50230-redhat-operators-recovery CronJob containers in
ns/openshift-marketplace.

This fixes the Sippy CI flake: [Monitor:termination-message-policy][sig-arch] all containers in ns/openshift-marketplace must have terminationMessagePolicy=FallbackToLogsOnError

Which Jira/Github issue(s) this PR fixes?

Fixes https://issues.redhat.com/browse/OCPBUGS-84517

Special notes for your reviewer:

Both CronJobs in openshift-marketplace were missing the policy. After this fix, the exemption for this namespace in openshift/origin can be removed.

Pre-checks (if applicable):

Tested latest changes against a cluster

Included documentation changes with PR

Summary by CodeRabbit

Bug Fixes

Improved how termination details are captured for two background CronJob tasks, so when pods exit unexpectedly, failure information is more reliable.

This enhances the quality of logs surfaced during operator recovery and source update workflows.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 30, 2026

openshift-ci Bot requested review from joshbranham and rogbas June 30, 2026 13:26

jrangelramos mentioned this pull request Jun 30, 2026

OCPBUGS-84517: Remove stale openshift-marketplace terminationMessagePolicy exemption openshift/origin#31355

Open

OCPBUGS-84517: Add terminationMessagePolicy to openshift-marketplace …

d815a53

…CronJobs Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

jrangelramos force-pushed the fix-terminationpolicy-osd-patch-sub-source branch from 410d57e to d815a53 Compare June 30, 2026 17:25

jrangelramos mentioned this pull request Jun 30, 2026

OCPBUGS-84517: Remove stale openshift-marketplace terminationMessagePolicy exemption openshift/origin#31357

Closed

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 30, 2026

openshift-ci Bot assigned joshbranham Jul 1, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2026

openshift-merge-bot Bot merged commit 00a0b2b into openshift:master Jul 1, 2026
4 checks passed

Uh oh!

Conversation

jrangelramos commented Jun 30, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this?

What this PR does / why we need it?

Which Jira/Github issue(s) this PR fixes?

Special notes for your reviewer:

Pre-checks (if applicable):

Summary by CodeRabbit

Uh oh!

openshift-ci-robot commented Jun 30, 2026

What type of PR is this?

What this PR does / why we need it?

Which Jira/Github issue(s) this PR fixes?

Special notes for your reviewer:

Pre-checks (if applicable):

Uh oh!

coderabbitai Bot commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Uh oh!

jrangelramos commented Jun 30, 2026

Uh oh!

openshift-ci-robot commented Jun 30, 2026

Uh oh!

jrangelramos commented Jul 1, 2026

Uh oh!

joshbranham commented Jul 1, 2026

Uh oh!

openshift-ci Bot commented Jul 1, 2026

Uh oh!

openshift-ci Bot commented Jul 1, 2026

Uh oh!

Uh oh!

openshift-ci-robot commented Jul 1, 2026

What type of PR is this?

What this PR does / why we need it?

Which Jira/Github issue(s) this PR fixes?

Special notes for your reviewer:

Pre-checks (if applicable):

Summary by CodeRabbit

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jrangelramos commented Jun 30, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 30, 2026 •

edited

Loading